Retry launch_app to fix OOM flakes #1144
Merged
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twometresteve
approved these changes
Jul 1, 2021
There was a problem hiding this comment.
I suspect it will continue to flake, but this is nice and simple and worth a shot.
We'll keep our ticket in play to investigate further - I'd look to put a mechanism into MR for retrying any action in Maze Runner a set number of times, waiting for a set time between.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
To fix flakes in the OOM scenario.
Changeset
The Appium logs revealed that the launch_app command sometimes fails when run after the fixture app has stopped running / been terminated.
This change will attempt a retry for the
I relaunch the appstep used by the OOM scenario.Testing
Was not able to reproduce the flake despite over 100 runs of the scenario on iOS 12.